Skip to content

mTLS support for batch and custom http object #2442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jay0lee wants to merge 3 commits into
base: main
Choose a base branch
from
Open

mTLS support for batch and custom http object #2442

jay0lee wants to merge 3 commits into from

Conversation

@jay0lee
Copy link
Contributor

@jay0lee jay0lee commented Jul 17, 2024

First stab at addressing #2440.

  • mTLS logic in build_from_document such as choosing the mtlsRootUrl should be executed even if we pass a custom http object in.
  • add an is_mtls bool attribute to Resource so we can make quick decisions about the state of mTLS later.
  • ensure our batch URI is using the mTLS host when is_mtls == True

feedback welcome.

@jay0lee jay0lee requested a review from a team as a code owner July 17, 2024 11:53
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jul 17, 2024
@jay0lee jay0lee mentioned this pull request Aug 5, 2024
Open
@gkevinzheng
Copy link

gkevinzheng commented Jan 27, 2026

@jay0lee: Sorry for being super late in responding to this PR. It seems that you've added a feature to fix an issue in the client. Could you add additional unit tests for the functionality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@vchudnov-g vchudnov-g

Labels

size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jay0lee @gkevinzheng @vchudnov-g @ohmayr